fix: add variable name validation for flux identifier #19317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlirieGray
force-pushed
the
variable-name-validation
branch
from
076d51d to
49412a9
Compare
AlirieGray
requested review from
a team,
GeorgeMac and
ebb-tide
and removed request for
a team
AlirieGray
force-pushed
the
variable-name-validation
branch
5 times, most recently
from
22ab237 to
36d46c5
Compare
AlirieGray
force-pushed
the
variable-name-validation
branch
from
36d46c5 to
6483ba2
Compare
GeorgeMac
approved these changes
Aug 17, 2020
AlirieGray
force-pushed
the
variable-name-validation
branch
from
6483ba2 to
9b4fef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation to the Variable kv service and to the UI validator to make sure that the name begins with a letter or underscore. This is because Variables should be valid Flux identifiers, as defined by the Flux docs here: https://github.com/influxdata/flux/blob/master/docs/SPEC.md#identifiers