Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add quotation marks to bucket name validation #19222

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

AlirieGray
Copy link
Contributor

@AlirieGray AlirieGray commented Aug 5, 2020

Closes #19179

This PR adds a check for quotation marks in the Bucket name when creating a Bucket. I checked other special symbols and only quotation marks seem to cause a problem for queries.

@AlirieGray AlirieGray force-pushed the bucket-name-validation branch from 19803d1 to e81348d Compare August 5, 2020 15:59
@AlirieGray AlirieGray changed the title wip fix: add quotation marks to bucket name validation Aug 5, 2020
@AlirieGray AlirieGray force-pushed the bucket-name-validation branch 3 times, most recently from 686dcb4 to 238b7bd Compare August 5, 2020 16:03
@AlirieGray AlirieGray requested review from a team, stuartcarnie, docmerlin and brettbuddin and removed request for a team, stuartcarnie, docmerlin and brettbuddin August 5, 2020 16:09
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks great. But could we get a test case for it?

@AlirieGray AlirieGray force-pushed the bucket-name-validation branch from 238b7bd to 827cf53 Compare August 5, 2020 16:22
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@AlirieGray AlirieGray force-pushed the bucket-name-validation branch 4 times, most recently from 3d2ea1e to 2456058 Compare August 5, 2020 19:17
@AlirieGray AlirieGray force-pushed the bucket-name-validation branch from 2456058 to cfef634 Compare August 5, 2020 19:19
@AlirieGray AlirieGray merged commit dd85de0 into master Aug 5, 2020
@AlirieGray AlirieGray deleted the bucket-name-validation branch August 5, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants