feat(paging): add support for after id parameter in find options #19219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
force-pushed
the
gm/find-options-after
branch
from
815e347 to
0bbf40e
Compare
GeorgeMac
force-pushed
the
gm/find-options-after
branch
2 times, most recently
from
ce61f65 to
054e025
Compare
GeorgeMac
force-pushed
the
gm/find-options-after
branch
from
054e025 to
685f0a1
Compare
GeorgeMac
requested review from
a team and
gavincabbage
and removed request for
a team
gavincabbage
approved these changes
Aug 21, 2020
There was a problem hiding this comment.
LGTM- will this help @RohanSreerama5's work on #19288 by any chance?
|
I am afraid not @gavincabbage |
brettbuddin
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19218
This PR adds support for the
afterparameter in theFindOptionsstruct.afteris more sympathetic to the structure and interfaces of our K/V store implementations; as opposed tooffset.The K/V stores we use support
seekoperations to particular keys, but not numerical index offsets like we expose through our APIs.To use this feature for pagination, you simply supply
afterwith the last ID observed in a list of results.This PR includes an implementation for
afterin both thetenantandkvbucket services.Outstanding:
Figure how widely used the paging links are leveraged and what needs to change to add support for auto-paging links usingafter.Im going to forgo forcing the use of after via the paging links for now as offset / limit suffice.