Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(influx): add telegraf resource support to influx CLI #18997

Merged
merged 1 commit into from
Jul 20, 2020
Merged

feat(influx): add telegraf resource support to influx CLI #18997

merged 1 commit into from
Jul 20, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Jul 20, 2020 •
edited
Loading

closes: #17654

@jsteenb2 jsteenb2 requested review from sanderson and mhall119 July 20, 2020 21:05
@jsteenb2 jsteenb2 force-pushed the 17654/influx_telegraf_cfg branch from 1ffd7fc to b8be3ff Compare July 20, 2020 21:05
@jsteenb2 jsteenb2 requested a review from samhld July 20, 2020 21:15
sanderson
sanderson suggested changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some capitalization and rewording.

cmd/influx/telegraf.go Outdated Show resolved Hide resolved
cmd/influx/telegraf.go Outdated Show resolved Hide resolved
cmd/influx/telegraf.go Outdated Show resolved Hide resolved
cmd/influx/telegraf.go Outdated Show resolved Hide resolved
cmd/influx/telegraf.go Outdated Show resolved Hide resolved
cmd/influx/telegraf.go Outdated Show resolved Hide resolved
cmd/influx/telegraf.go Outdated Show resolved Hide resolved
cmd/influx/telegraf.go Outdated Show resolved Hide resolved
cmd/influx/telegraf.go Outdated Show resolved Hide resolved
cmd/influx/telegraf.go Outdated Show resolved Hide resolved
@jsteenb2 jsteenb2 force-pushed the 17654/influx_telegraf_cfg branch from b8be3ff to 883f9a1 Compare July 20, 2020 21:49
@jsteenb2 jsteenb2 requested a review from sanderson July 20, 2020 21:50
@jsteenb2 jsteenb2 force-pushed the 17654/influx_telegraf_cfg branch from 883f9a1 to 1b8bcb6 Compare July 20, 2020 21:52
@jsteenb2 jsteenb2 force-pushed the 17654/influx_telegraf_cfg branch from 1b8bcb6 to 4595b79 Compare July 20, 2020 21:55
sanderson
sanderson approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://media.giphy.com/media/MGYY2FIs8VrfW/giphy.gif

@sanderson sanderson mentioned this pull request Jul 20, 2020
Closed
1 task
@jsteenb2 jsteenb2 merged commit 86894d4 into master Jul 20, 2020
@jsteenb2 jsteenb2 deleted the 17654/influx_telegraf_cfg branch July 20, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderson sanderson sanderson approved these changes

@mhall119 mhall119 Awaiting requested review from mhall119

@samhld samhld Awaiting requested review from samhld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add the ability to manage telegraf configurations via the CLI
2 participants
@jsteenb2 @sanderson