feat: Dashboards maintain sort order after navigating away #18400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reparker837
force-pushed
the
rp_save_board_sort_order
branch
from
1234b80 to
983e34e
Compare
hoorayimhelping
requested review from
a team and
asalem1
and removed request for
a team
asalem1
approved these changes
Jun 8, 2020
| @@ -6,6 +6,10 @@ import {Cell, Dashboard, RemoteDataState} from 'src/types' | |||
| import {DecimalPlaces} from 'src/types' | |||
| import {DEFAULT_TIME_FORMAT} from 'src/shared/constants' | |||
|
|
|||
| import {SortTypes} from 'src/shared/utils/sort' | |||
| import {Sort} from '@influxdata/clockface' | |||
| import {DashboardSortKey} from 'src/shared/components/resource_sort_dropdown/generateSortItems' | |||
There was a problem hiding this comment.
🤔 it's strange that this type is being set in a decentralized location. It might be beyond the scope of this PR to move this to src/types but it is worth considering doing that as a fast follow-up
There was a problem hiding this comment.
good suggestion, but I think it's beyond this PR's scope to do that.
reparker837
force-pushed
the
rp_save_board_sort_order
branch
from
983e34e to
15a5103
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15292
Dashboard page remembers sort order when you go to a different page–does not save across page reloads.