fix(api/health): report version #18173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally, I wouldn't mind seeing the commit in there too. |
sranka
force-pushed
the
13907/addVersionToHealth
branch
2 times, most recently
from
d60b86a to
2e4b537
Compare
glinton
reviewed
May 20, 2020
http/health.go
Outdated
| ) | ||
|
|
||
| // HealthHandler returns the status of the process. | ||
| func HealthHandler(w http.ResponseWriter, r *http.Request) { | ||
| msg := `{"name":"influxdb", "message":"ready for queries and writes", "status":"pass", "checks":[]}` | ||
| msg := fmt.Sprintf(`{"name":"influxdb", "message":"ready for queries and writes", "status":"pass", "checks":[], "version": %q}`, platform.GetBuildInfo().Version) |
There was a problem hiding this comment.
The more i think about it, the more valuable i feel like commit would be in here. (platform.GetBuildInfo().Commit) 🤷♂️
There was a problem hiding this comment.
A new "commit" field? I can add it as well herein.
sranka
force-pushed
the
13907/addVersionToHealth
branch
from
85912c0 to
c35c90a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13907
InfluxDB 1.8 "/health" endpoint already returns version,
This PR also adds version to 2.0 "/health" endpoint