fix(variable_hydration): limiting variable hydration to changing variables #18071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdelambre
suggested changes
May 12, 2020
asalem1
force-pushed
the
fix/variable-hydration
branch
2 times, most recently
from
928f4c6 to
c9f1eff
Compare
drdelambre
reviewed
May 19, 2020
| // use an ID array to reduce the chance of reference errors | ||
| const varIDs = variables.map(v => v.id) | ||
| // create an array of IDs to reference later | ||
| const graphIDs = [] |
There was a problem hiding this comment.
note for self: this was because Set.prototype.has compares by reference, which we dont guarantee in an immutable kind of world
drdelambre
reviewed
May 19, 2020
| // use an ID array to reduce the chance of reference errors | ||
| const varIDs = variables.map(v => v.id) | ||
| // create an array of IDs to reference later | ||
| const graphIDs = [] |
There was a problem hiding this comment.
nit for Ari: this should be an object for a faster lookup on line 148, but i can't imagine the search space being very large, so it's not a blocker
… triggering onSelectValue for VariableDropdown
…tion purposes and added some filter logic to subgraphs
…test. Need to write unit tests to validate work
asalem1
force-pushed
the
fix/variable-hydration
branch
from
80d9205 to
ba108df
Compare
drdelambre
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/influxdata/idpe/issues/7030
Problem
This PR aims to address the issue of overly hydrating variables when a variable selection is made.
Solution
The solution to this is twofold:
Here's how these changes impact the network requests:
UI Tweak
This PR also includes a minor UI tweak that may have been the result of the clockface pendulum update.
Previous:
Now:
