fix(kv): Ensure UpdateUser cleans up the index when updating names #17906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettbuddin
force-pushed
the
bb/update-user-index
branch
2 times, most recently
from
55db411 to
5a6eb5e
Compare
brettbuddin
force-pushed
the
bb/update-user-index
branch
from
5a6eb5e to
af4f8e4
Compare
lyondhill
approved these changes
Apr 29, 2020
docmerlin
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateUserisn't cleaning up theuserindexv1/<USER_NAME>index when the name of a user is changed. This change ensures that this key is removed properly.This work will be superseded by the new tenant service.