Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(influx): make CLI respect env vars and flags in addition to the configs #17817

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Apr 21, 2020

Closes #17812

@jsteenb2 jsteenb2 requested a review from bthesorceror April 21, 2020 16:59
@jsteenb2 jsteenb2 force-pushed the 17812/influx_host_env_var branch from 1911858 to fe3d3ba Compare April 21, 2020 16:59
@jsteenb2 jsteenb2 changed the title bug(influx): make CLI respect env vars and flags in addition to the configs fix(influx): make CLI respect env vars and flags in addition to the configs Apr 21, 2020
@jsteenb2 jsteenb2 force-pushed the 17812/influx_host_env_var branch from fe3d3ba to 9f03c29 Compare April 21, 2020 17:01
…nn to config

one thing to note here is we are deleting the default value on the host
flag when it is registered. The config is the fallback and has the default
value set. If the host flag has a default, the determination if the user
set it or not is ambiguous. We can't have that.

closes: #17812
@jsteenb2 jsteenb2 force-pushed the 17812/influx_host_env_var branch from 9f03c29 to 41c216b Compare April 21, 2020 17:05
@jsteenb2 jsteenb2 merged commit 43b7d65 into master Apr 21, 2020
@jsteenb2 jsteenb2 deleted the 17812/influx_host_env_var branch April 21, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INFLUX_HOST variable has no effect on the behaviour of the influx utility
2 participants