fix(ui): add error messaging for cells in dashdboard view #17754
Conversation
TCL735
requested review from
alexpaxton,
a team,
ebb-tide and
drdelambre
and removed request for
a team
|
Overall looks good, there are these massive gaps between the error box and the cell header. Not sure where that gap is coming from, but I am happy to pair on removing it if that helps |
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| See https://github.com/influxdata/flux/blob/master/docs/SPEC.md#errors. | |||
| */ | |||
| export const checkQueryResult = (file: string): void => { | |||
| export const checkQueryResult = (file: string = ''): void => { | |||
There was a problem hiding this comment.
checkQueryResult is called here
At runtime, result.csv may be undefined (not a string) when there is an error. The code immediately above the call to checkQueryResult throws a runtime error which will hide the fact that checkQueryResult will throw its own error when result.csv is not a string.
By adding a default value to the parameter we prevent checkQueryResult from throwing its own error (which would be visible in the console should the throws above it are ever removed).
There was a problem hiding this comment.
Specifically, the error messaging will become checkQueryResult's thrown error rather than the actual error. And we want the error message to be useful to the user (rather than the dev). The user won't care or know what to do with "Cannot read property 'slice' of undefined"
|
@alexpaxton Gaps are removed. I have updated the screenshots. |
Closes #17594
Add error messaging for cells in the Dashboard View.
Example: when one cell has error
Example: when all cells have error
