Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): sort getting started dashboards by modified #17657

Merged
merged 5 commits into from
Apr 8, 2020
Merged

feat(ui): sort getting started dashboards by modified #17657

merged 5 commits into from
Apr 8, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Apr 7, 2020 •
edited
Loading

Closes #17545

  • Make dashboards panel scrollable after a certain height (400px)
  • Make long dashboard names wrap
  • Sort dashboards by modified date
  • Add filter input
  • Increase size of dashboard names and handy tutorials

Screen Shot 2020-04-07 at 11 44 36 AM

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested review from a team and ebb-tide and removed request for a team April 7, 2020 18:48
ebb-tide
ebb-tide approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 🍰 🍰

ui/src/me/components/DashboardsList.tsx

if (dashboards && dashboards.length) {
let recentlyModifiedDashboards = sortBy(dashboards, [
'meta.updatedAt',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried this wouldn't work but it does! :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(because of the format of our dates..)

@alexpaxton alexpaxton merged commit 0b94b09 into master Apr 8, 2020
@alexpaxton alexpaxton deleted the feat/recent-dashboards branch April 8, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebb-tide ebb-tide ebb-tide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move "recently used" dashboards to top of list on Getting Started page
2 participants
@alexpaxton @ebb-tide