-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): resource sorting dropdowns #17321
Conversation
sortDirection={sortDirection} | ||
sortType={sortType} | ||
onFilterChange={onFilterChange} | ||
if (searchTerm) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting gnarly enough were it might be better as its own component. DashboardEmptyState
) | ||
} | ||
|
||
export default TasksSortDropdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks almost identical to the DashboardSortDropdown
. I'm down to work with you on making one SortDropdown
component that can take additional labels
to sort by.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! that would be excellent as we'll probs roll this out to other parts of the UI and having a generic component would be great
Closes #16967
Goals
Changes
Preview
Dashboards & Tasks:
Load Data Tabs:
Settings:
Tabbed Page Headers on small screen: