fix(ui): updated default positioning for adding aggregate funcs when toggling from query builder #17028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalem1
commented
Feb 27, 2020
| @@ -20,7 +20,7 @@ export const formatFunctionForInsert = ( | |||
| return `\n${fluxFunction}` | |||
| } | |||
|
|
|||
| return ` |> ${fluxFunction}` | |||
| return `\n |> ${fluxFunction}` | |||
There was a problem hiding this comment.
ensures that all selected aggregate functions are inserted onto a new line
asalem1
force-pushed
the
regression/script-default-position
branch
from
38e8289 to
4b2f192
Compare
121watts
suggested changes
Mar 3, 2020
…toggling from query builder
…nc bug that was triggering tests to fail
asalem1
force-pushed
the
regression/script-default-position
branch
from
4b2f192 to
a365b5b
Compare
121watts
approved these changes
Mar 3, 2020
jacobmarble
pushed a commit
that referenced
this pull request
Mar 12, 2020
…toggling from query builder (#17028) fix(ui): updated default positioning for adding aggregate funcs when toggling from query builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16668
Problem
Currently toggling from the query builder to the script editor will default aggregate functions that are selected to the initial part of the query.
Solution
Create a conditional check to update the range that we are adding to to be the end of the existing query. Also added logic to add a new line whenever an aggregate function is selected.