Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): update giraffe #16973

Merged
merged 2 commits into from
Feb 21, 2020
Merged

fix(ui): update giraffe #16973

merged 2 commits into from
Feb 21, 2020

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Feb 21, 2020

Closes influxdata/giraffe#158

Updates giraffe to consume the new version

  • Correctly calculates the cumulative values for stacked line graphs when lines are different lengths

@TCL735 TCL735 requested a review from a team February 21, 2020 21:52
@ghost ghost requested review from ebb-tide and removed request for a team February 21, 2020 21:52
@TCL735 TCL735 requested a review from glinton February 21, 2020 21:59
glinton
glinton approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@TCL735 TCL735 merged commit d96f3dc into master Feb 21, 2020
@TCL735 TCL735 deleted the fix_158_update_giraffe branch February 21, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebb-tide ebb-tide ebb-tide approved these changes

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stacked line cumulative is incorrect when lines do not cover the same time range
3 participants
@TCL735 @glinton @ebb-tide