fix(tasks): add content length check to decode force run request #16458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlirieGray
force-pushed
the
task/run-api-bug
branch
from
6d037e8 to
37e3799
Compare
AlirieGray
force-pushed
the
task/run-api-bug
branch
from
37e3799 to
0dd7b31
Compare
AlirieGray
force-pushed
the
task/run-api-bug
branch
from
0dd7b31 to
81c69b4
Compare
docmerlin
approved these changes
Jan 8, 2020
ghost
requested review from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where manually running a task failed with an "EOF" error. The solution was to check for the length of the request body, and only decode the body if it is not empty. We also check that the response body is not too long, since there is only one expected property in the body at most.