chore(ui): refactored dashboards client API to oats generated types and API #16438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalem1
commented
Jan 7, 2020
| @@ -81,8 +117,8 @@ export enum ActionTypes { | |||
| DeleteDashboardFailed = 'DELETE_DASHBOARD_FAILED', | |||
| EditDashboard = 'EDIT_DASHBOARD', | |||
| RemoveCell = 'REMOVE_CELL', | |||
| AddDashboardLabels = 'ADD_DASHBOARD_LABELS', | |||
There was a problem hiding this comment.
unpluralized these to accurately reflect their functionality
| @@ -262,6 +298,46 @@ export const createDashboard = () => async ( | |||
| } | |||
| } | |||
|
|
|||
| export const cloneUtilFunc = async (dash: Dashboard, id: string) => { | |||
There was a problem hiding this comment.
this utility function is based on the client-api:
My first attempt at this refactor tried to flatten these into a synchronous progression, but the functionality was buggy.
19 tasks
ebb-tide
approved these changes
Jan 10, 2020
ui/src/dashboards/actions/index.ts
Outdated
|
|
||
| // Constants | ||
| import * as copy from 'src/shared/copy/notifications' | ||
| import {DEFAULT_DASHBOARD_NAME} from 'src/dashboards/constants/index' | ||
|
|
||
| // Types | ||
| import {RemoteDataState} from 'src/types' | ||
| import {CreateCell} from '@influxdata/influx' |
There was a problem hiding this comment.
Can this come from new client as well?
There was a problem hiding this comment.
I’ll give a shot on Monday morning and if there aren’t any conflict/cascading issues then it’ll be in the PR :)
| @@ -38,6 +39,7 @@ export type NewCell = Omit<Cell, 'id' | 'links' | 'dashboardID'> | |||
|
|
|||
| export interface Dashboard extends Omit<GenDashboard, 'cells'> { | |||
| cells: Cell[] | |||
| labels: Label[] | |||
asalem1
force-pushed
the
dashboard-client-chore
branch
from
684a3c8 to
61cef2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16393
Problem
Current API and types are dependent upon deprecated client API
Solution
Refactored the variables to utilize the new oats generated client API