Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show queries built in advanced mode when switching tabs #16427

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

hoorayimhelping
Copy link
Contributor

@hoorayimhelping hoorayimhelping commented Jan 7, 2020

Closes #16169

If a query isn't a valid QueryBuilder query, but it still has text (in other words, it was built using the script editor, or by the system), use the text, rather than blanking the text out.

@hoorayimhelping hoorayimhelping force-pushed the bs_fix_disappearing_advanced_queries branch 4 times, most recently from 73f0f56 to ef8531c Compare January 7, 2020 21:56
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier:fix

@hoorayimhelping hoorayimhelping force-pushed the bs_fix_disappearing_advanced_queries branch 3 times, most recently from b67c10b to 56f3548 Compare January 7, 2020 22:33
@hoorayimhelping hoorayimhelping requested a review from a team January 7, 2020 22:34
@ghost ghost requested review from 121watts and drdelambre and removed request for a team January 7, 2020 22:34
@hoorayimhelping hoorayimhelping force-pushed the bs_fix_disappearing_advanced_queries branch from 56f3548 to 6291595 Compare January 7, 2020 22:35
Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔎 :shipit: 🔍

@hoorayimhelping hoorayimhelping merged commit 81365b9 into master Jan 7, 2020
@mark-rushakoff mark-rushakoff deleted the bs_fix_disappearing_advanced_queries branch April 16, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryBuilder: valid queries with invalid BuilderConfigs cause wonky tab behavior
2 participants