chore(inmem): nuke the duplicative inmem service implementation #16347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
changed the title
jsteenb2
changed the title
jsteenb2
force-pushed
the
nuke/inmem
branch
3 times, most recently
from
6b6c4f1 to
874d4fa
Compare
|
I saw source.go is still there. Are we still using that? |
|
@kelwang good catch, and yah, there are a few files left in inmem that are necessary for idpe. I'll double back on the source.go specifically though. Pretty sure its needed for something in the idpe |
use kv store... its a thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm coming for you next bolt store 📻