chore(ui): upgrade to Clockface 1.1.0 #16144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 968a823.
ghost
requested review from
hoorayimhelping and
TCL735
and removed request for
a team
|
Ran this locally. Looks good. However, the e2e tests are failing. |
|
I am working on some updates to the e2e tests. Standby... Edit: explorer.tests.ts needs some updates, as well as the issue described in the next comment. Edit 2: fixed |
|
PanelBody for the AlertsColumn has no height, causing the Notification Endpoints column to hide all its contents, which in turn causes the notificationEndpoints e2e tests to fail Edit: fixed |
TCL735
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radiorenamed toSelectGroupPanelTitleis deprecated, replaced with heading elementsPopoverTypeenum renamed toAppearanceSlideToggleLabelis deprecated, replaced withInputLabel