Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): handle json parsing failures and let the user know #16101

Merged
merged 1 commit into from
Dec 3, 2019
Merged

fix(ui): handle json parsing failures and let the user know #16101

merged 1 commit into from
Dec 3, 2019

Conversation

hoorayimhelping
Copy link
Contributor

@hoorayimhelping hoorayimhelping commented Dec 3, 2019 •
edited
Loading

Closes Honeybadger:#3

Wrap JSON.parse calls in the interface in try/catch blocks, and display the error message (usually a cryptic parsing error) to the user.

template

Related:

#16099

@hoorayimhelping hoorayimhelping requested a review from a team December 3, 2019 21:13
@ghost ghost requested review from asalem1 and desa and removed request for a team December 3, 2019 21:13
@hoorayimhelping hoorayimhelping changed the title feature(ui): handle json parsing failures and let the user know feat(ui): handle json parsing failures and let the user know Dec 3, 2019
@hoorayimhelping hoorayimhelping changed the title feat(ui): handle json parsing failures and let the user know fix(ui): handle json parsing failures and let the user know Dec 3, 2019
@hoorayimhelping hoorayimhelping force-pushed the bs_unsafe_json_access_ui branch from 66a1060 to f514a71 Compare December 3, 2019 21:16
@hoorayimhelping hoorayimhelping requested a review from a team December 3, 2019 21:20
@hoorayimhelping hoorayimhelping force-pushed the bs_unsafe_json_access_ui branch from f514a71 to 3913217 Compare December 3, 2019 21:29
@hoorayimhelping hoorayimhelping merged commit 5801d9c into master Dec 3, 2019
@hoorayimhelping hoorayimhelping deleted the bs_unsafe_json_access_ui branch December 3, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdelambre drdelambre drdelambre approved these changes

@asalem1 asalem1 Awaiting requested review from asalem1

@desa desa Awaiting requested review from desa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoorayimhelping @drdelambre