Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): don't show members information in cloud #15866

Merged
merged 1 commit into from
Nov 12, 2019
Merged

fix(ui): don't show members information in cloud #15866

merged 1 commit into from
Nov 12, 2019

Conversation

hoorayimhelping
Copy link
Contributor

@hoorayimhelping hoorayimhelping commented Nov 12, 2019 •
edited
Loading

Closes influxdata/idpe#5244

Hide Members tabs and navigation options in Cloud environments.

Testing instructions

While logged in, change this line to true. It should change your environment to cloud and change the navigation.

drdelambre
drdelambre approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starting to look like a feature and not a bug 🤔

ebb-tide
ebb-tide suggested changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to change routes in index.tsx

ebb-tide
ebb-tide reviewed Nov 12, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ebb-tide
ebb-tide reviewed Nov 12, 2019
View reviewed changes
ui/src/index.tsx Outdated Show resolved Hide resolved
ui/src/pageLayout/containers/Nav.tsx Show resolved Hide resolved
ui/src/pageLayout/containers/Nav.tsx Outdated Show resolved Hide resolved
ebb-tide
ebb-tide approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 🍰 🍰

@hoorayimhelping hoorayimhelping merged commit bcc0aa8 into master Nov 12, 2019
@hoorayimhelping hoorayimhelping deleted the bs_fix_members_in_cloud branch November 12, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalem1 asalem1 asalem1 approved these changes

@ebb-tide ebb-tide ebb-tide approved these changes

@121watts 121watts 121watts approved these changes

@desa desa desa approved these changes

@drdelambre drdelambre drdelambre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hoorayimhelping @drdelambre @desa @121watts @ebb-tide @asalem1