Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (ui): Horizontal and vertical scroll hiding elements #15628

Merged
merged 5 commits into from
Oct 31, 2019

Conversation

zoesteinkamp
Copy link
Contributor

The vertical scroll on the variable page was not displaying the last element

The horizontal scroll on the filter scroll was covering the bottom scroll, this is probably happening in other places

Closes #13943

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@zoesteinkamp zoesteinkamp force-pushed the zs-horizontalscrollbar-13943 branch 4 times, most recently from 84dbd2b to fb2a906 Compare October 31, 2019 17:58
The vertical scroll on the variable page was not displaying the last element

The horizontal scroll on the filter scroll was covering the bottom scroll, this is probably happening in other places
Fixing jetest error with margin bottom
@zoesteinkamp zoesteinkamp force-pushed the zs-horizontalscrollbar-13943 branch from f14a5e5 to eec51dd Compare October 31, 2019 21:41
@zoesteinkamp zoesteinkamp requested a review from a team October 31, 2019 22:23
Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zoesteinkamp zoesteinkamp merged commit 08d0fc2 into master Oct 31, 2019
@zoesteinkamp zoesteinkamp deleted the zs-horizontalscrollbar-13943 branch October 31, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

horizontal scrollbar not on top in data explorer
2 participants