fix(ui): exiting out of a configure cell leaves cell content intact #15559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoorayimhelping
changed the title
ghost
requested review from
121watts and
drdelambre
and removed request for
a team
121watts
approved these changes
Oct 24, 2019
hoorayimhelping
force-pushed
the
bs_fix_spooky_disappearing_dashboard_content_
branch
from
e6f36d8 to
f00f7b2
Compare
hoorayimhelping
deleted the
bs_fix_spooky_disappearing_dashboard_content_👻
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15239
When the view editor overlay is loaded,
getViewForTimeMachineis called.getViewForTimeMachinechecks the store for the relevantviewbased on theviewIDpassed in to the function. Previously (the buggy state),getViewForTimeMachinedispatched aSET_VIEWaction with anullview, even ifviewalready existed in the store. Now, it only dispatches a null view if there is no view.Note:
e2e tests are waiting on #15538 since the changes Deniz is making are necessary for me to write tests on this component.