Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): redesign all page headers to make use of PageSubTitle #15503

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Oct 18, 2019

Closes #15494

Screen Shot 2019-10-18 at 10 26 46 AM
Screen Shot 2019-10-18 at 10 26 55 AM

This PR aims to make the page headers more compact by splitting the text into 2 lines. On most pages the subtitle is the current org name, and on the home page there's an explainer line for the random language greeting.

This should help with real estate issues on dashboard headers (long org names + long dashboard names exacerbate the issue)

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team October 18, 2019 17:35
@ghost ghost requested review from drdelambre and hoorayimhelping and removed request for a team October 18, 2019 17:35
Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexpaxton alexpaxton merged commit aa34444 into master Oct 18, 2019
@mark-rushakoff mark-rushakoff deleted the refactor/page-sub-headers branch April 16, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SubTitle to all PageTitle components
2 participants