Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gateway): log error on unauthorized attempt #15452

Merged
merged 1 commit into from
Oct 17, 2019
Merged

chore(gateway): log error on unauthorized attempt #15452

merged 1 commit into from
Oct 17, 2019

Conversation

GeorgeMac
Copy link
Contributor

@GeorgeMac GeorgeMac commented Oct 17, 2019 •
edited
Loading

This is to gain some small visibility into the reason behind a failed authorization.
Now when a user receives an unauthorized error, an info level log message is written to STDOUT containing the error which produced it.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@GeorgeMac GeorgeMac force-pushed the gm/authorization-logger branch from b39f509 to 3bc113e Compare October 17, 2019 16:33
@GeorgeMac GeorgeMac requested a review from a team October 17, 2019 16:33
@ghost ghost requested review from AlirieGray and removed request for a team October 17, 2019 16:33
@GeorgeMac GeorgeMac requested a review from e-dard October 17, 2019 16:43
AlirieGray
AlirieGray approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@AlirieGray AlirieGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@GeorgeMac GeorgeMac merged commit b3b2f52 into master Oct 17, 2019
@GeorgeMac GeorgeMac deleted the gm/authorization-logger branch October 17, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlirieGray AlirieGray AlirieGray approved these changes

@e-dard e-dard e-dard approved these changes

Assignees
No one assigned
Labels
area/api area/auth team/compute
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeorgeMac @e-dard @AlirieGray