Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): introduce "Load Data" tab #14709

Merged
merged 10 commits into from
Aug 20, 2019
Merged

refactor(ui): introduce "Load Data" tab #14709

merged 10 commits into from
Aug 20, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Aug 19, 2019 •
edited
Loading

  • Create Load Data tab
  • Move Buckets, Telegrafs, and Scrapers from settings into load data
  • Extend URL activator utility to scan URLs of any length
  • Change orientation of tabs in settings page to be horizontal

Screen Shot 2019-08-19 at 11 28 35 AM

Created this issue: #14708

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team August 19, 2019 18:35
@ghost ghost requested review from desa and removed request for a team August 19, 2019 18:35
desa
desa approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@desa desa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@alexpaxton alexpaxton merged commit 450b85f into master Aug 20, 2019
@alexpaxton alexpaxton deleted the refactor/load-data-tab branch August 20, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desa desa desa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpaxton @desa