feat(tasks): add ability to find tasks by name #14694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
AlirieGray
force-pushed
the
tasks/find-by-name
branch
from
c141242 to
896f08e
Compare
lyondhill
approved these changes
Aug 16, 2019
kv/task.go
Outdated
| return ts, len(ts), err | ||
| } | ||
|
|
||
| func filterByName(ts []*influxdb.Task, name string) []*influxdb.Task { |
There was a problem hiding this comment.
Add tasks to name. Just so it's clear is not generic
AlirieGray
force-pushed
the
tasks/find-by-name
branch
from
896f08e to
bf5a6b4
Compare
AlirieGray
force-pushed
the
tasks/find-by-name
branch
from
bf5a6b4 to
28089fd
Compare
kelwang
approved these changes
Aug 16, 2019
|
@kelwang No they are not necessarily unique. If there are multiple tasks with the same name, it will just return an array with those tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12170
Adds ability to find tasks with a name specified in the query parameters. An exact matched is used, to be consistent with the way filtering by name works with other resources such as buckets.
For example, a request to
http://localhost:9999/api/v2/tasks?name=mytaskwill return the task(s) with the namemytask