Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tasks): sort runs by most recently scheduled #14604

Merged
merged 1 commit into from
Aug 12, 2019
Merged

feat(tasks): sort runs by most recently scheduled #14604

merged 1 commit into from
Aug 12, 2019

Conversation

AlirieGray
Copy link
Contributor

@AlirieGray AlirieGray commented Aug 8, 2019 •
edited
Loading

Closes #14439

This PR sorts runs in the handleGetRuns function in task_service.go by most recent scheduledFor time.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass

@AlirieGray AlirieGray changed the title fix(tasks): sort runs by most recently scheduled feat(tasks): sort runs by most recently scheduled Aug 8, 2019
@AlirieGray AlirieGray force-pushed the tasks/sort-runs-by-time-scheduled branch from abd0909 to 0cae89d Compare August 8, 2019 23:04
@AlirieGray AlirieGray requested a review from a team August 8, 2019 23:04
@ghost ghost requested review from lyondhill and removed request for a team August 8, 2019 23:04
@AlirieGray AlirieGray force-pushed the tasks/sort-runs-by-time-scheduled branch from 0cae89d to 766368e Compare August 8, 2019 23:10
lyondhill
lyondhill suggested changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@lyondhill lyondhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better as part of the flux script using a sort function (docs). That would allow you to add a sort test in service test

@AlirieGray AlirieGray force-pushed the tasks/sort-runs-by-time-scheduled branch from 766368e to f4a8972 Compare August 12, 2019 18:38
@AlirieGray AlirieGray force-pushed the tasks/sort-runs-by-time-scheduled branch from f4a8972 to 16c400c Compare August 12, 2019 19:32
lyondhill
lyondhill approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@lyondhill lyondhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM!

@AlirieGray AlirieGray merged commit 02765c6 into master Aug 12, 2019
@AlirieGray AlirieGray deleted the tasks/sort-runs-by-time-scheduled branch August 12, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyondhill lyondhill lyondhill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task runs should be returned most recently scheduled first
2 participants
@AlirieGray @lyondhill