Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish/query builder checkboxes #13835

Merged
merged 7 commits into from
May 7, 2019
Merged

Polish/query builder checkboxes #13835

merged 7 commits into from
May 7, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented May 7, 2019 •
edited
Loading

Screen Shot 2019-05-07 at 2 12 11 PM

To reduce confusion about what kind of interactions happen in the query builder lists the SelectorList component can optionally be configured to be multiSelect which renders checkboxes within each list item

  • Bucket selector: Single
  • Tag selector: Multi
  • Function selector: Multi

Checklist

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

Palakp41
Palakp41 approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@Palakp41 Palakp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! looks good! :)

@alexpaxton alexpaxton merged commit c32f2df into master May 7, 2019
@alexpaxton alexpaxton deleted the polish/query-builder-checkboxes branch May 7, 2019 22:48
@chnn chnn mentioned this pull request May 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Palakp41 Palakp41 Palakp41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpaxton @Palakp41