-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(influxdb): rename telegraf orgID #13411
Conversation
0be9554
to
f79dab5
Compare
070f8a6
to
90f1dd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend changes look fine to me. This needs a review from someone on chronograf before it can be merged. We may want to hold off on API changes until after our upcoming milestone.
22d14af
to
9967658
Compare
ui/package-lock.json
Outdated
"resolved": "https://registry.npmjs.org/@influxdata/influx/-/influx-0.3.4.tgz", | ||
"integrity": "sha512-WUkugWDdvG5BpdRtdrFPnevFlJOmxod3t91cUuTcUiGdYATqCnVgMYvjmK0oXu/8DFrGAZlzg/u4vMQq8ndhnA==", | ||
"version": "github:influxdata/influxdb2-js#986c7b3ee77e22a10208688b49edcf85ef354be1", | ||
"from": "github:influxdata/influxdb2-js#telegraf_rename_orgID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was set during testing and should be reverted
ui/package.json
Outdated
@@ -140,7 +140,7 @@ | |||
}, | |||
"dependencies": { | |||
"@influxdata/clockface": "0.0.13", | |||
"@influxdata/influx": "0.3.4", | |||
"@influxdata/influx": "github:influxdata/influxdb2-js#telegraf_rename_orgID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is good to go once package.json
has been reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preemptively approving this. Once influxdata/influxdb-client-js#115 is approved, we can change the package.json
back.
9967658
to
fe01f36
Compare
fe01f36
to
7a40d92
Compare
Closes #13147
rename telegraf config's OrganizationID to OrgID
only merged after #13404 resolved