Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Add create org to side nav #13173

Merged
merged 1 commit into from
Apr 5, 2019
Merged

feat(ui): Add create org to side nav #13173

merged 1 commit into from
Apr 5, 2019

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented Apr 4, 2019 •
edited
Loading

Closes #13158

Briefly describe your proposed changes:
new_org

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@ischolten ischolten force-pushed the feat/create-org-nav branch 5 times, most recently from a9d5435 to c33f6e1 Compare April 4, 2019 23:42
alexpaxton
alexpaxton approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nits. I have some thoughts about routes + overlays but I think that's a bigger discussion than the scope of this PR

ui/cypress/e2e/buckets.test.ts Outdated Show resolved Hide resolved
ui/src/pageLayout/containers/Nav.tsx Outdated Show resolved Hide resolved
@ischolten ischolten force-pushed the feat/create-org-nav branch from c33f6e1 to 05df47d Compare April 5, 2019 00:10
@ischolten ischolten merged commit f15dea3 into master Apr 5, 2019
@ischolten ischolten deleted the feat/create-org-nav branch April 5, 2019 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpaxton alexpaxton alexpaxton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ischolten @alexpaxton