Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12892
If a user's session expires while they are viewing a modal, they will be taken through the following router flow:
Start at
Open modal, pushes modal route onto stack
Session expires, push signin route onto stack
After signin, push
returnTo
onto stackDismiss modal, which pops last route
This creates an infinite loop 💥
Instead, we want:
Start at
Open modal, pushes modal route onto stack
Session expires, replace current route with signin route
After signin, replace sign in route with
returnTo
routeDismiss modal, which pops last route