Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure editor is focused when editing/creating note #12850

Merged
merged 1 commit into from
Mar 22, 2019
Merged

ensure editor is focused when editing/creating note #12850

merged 1 commit into from
Mar 22, 2019

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented Mar 22, 2019 •
edited
Loading

Closes #12506

Briefly describe your proposed changes:
call focus to editor once editor mounts.

note-focus

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@ischolten ischolten force-pushed the fix/note-auto-focus branch from 63f085a to 433f99f Compare March 22, 2019 22:01
chnn
chnn approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@ischolten ischolten merged commit 6840050 into master Mar 22, 2019
@ischolten ischolten deleted the fix/note-auto-focus branch March 22, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chnn chnn chnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ischolten @chnn