Migrate influxd binary to cobra Command package #12615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcarnie
force-pushed
the
sgc/cobra-command
branch
from
7317fea to
f7dc808
Compare
e-dard
approved these changes
Mar 13, 2019
jacobmarble
reviewed
Mar 14, 2019
cmd/influxd/launcher/launcher.go
Outdated
| { | ||
| DestP: &l.logLevel, | ||
| Flag: "log-level", | ||
| Default: "info", |
There was a problem hiding this comment.
I wouldn't mind zapcore.InfoLevel.String() but not important.
jacobmarble
approved these changes
Mar 14, 2019
Permits binary packages to set a global BuildInfo state that can be inspected by other packages
This commit consists of several improvements or changes: * migrate the influxd binary to cobra.Command * introduce a default run sub-command to start the server * register the run sub-command flags with viper to maintain compatibility with the existing behavior of automatic binding of flags to environment variables. Closes #12602
* Add CHANGELOG entry * Remote erroneous comment
stuartcarnie
force-pushed
the
sgc/cobra-command
branch
from
53f4f18 to
c8d70fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of several improvements or changes to the
influxdbinary:influxdbinary to thecobraCLI packagerunsubcommand to start the serverruncommand by default, if no sub-command is specifiedrunsubcommand flags with viper. This ensures compatibility with the existing behavior of automatic binding of flags to environment variables.Closes #12602