Inline Label Editing from Dashboards Index #12384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Delmer <[email protected]>
Co-Authored-By: Delmer <[email protected]>
Co-Authored-By: Andrew Watkins <[email protected]>
…fluxdata/influxdb into feat/dashboards-inline-labels
Everything the unit test is testing is also tested by the e2e test Co-Authored-By: Delmer <[email protected]>
Co-Authored-By: Delmer <[email protected]> Co-Authored-By: Andrew Watkins <[email protected]>
Co-Authored-By: Delmer <[email protected]> Co-Authored-By: Andrew Watkins <[email protected]>
Co-Authored-By: Delmer <[email protected]> Co-Authored-By: Andrew Watkins <[email protected]>
mavarius
reviewed
Mar 7, 2019
proto/bin_gen.go
Outdated
| @@ -84,7 +84,7 @@ func systemJson() (*asset, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| info := bindataFileInfo{name: "system.json", size: 30129, mode: os.FileMode(420), modTime: time.Unix(1548273842, 0)} | |||
| info := bindataFileInfo{name: "system.json", size: 30129, mode: os.FileMode(420), modTime: time.Unix(1548960115, 0)} | |||
There was a problem hiding this comment.
What is this? Was it meant to be part of this PR?
There was a problem hiding this comment.
I’ll have to revert these changes
| if (onDelete) { | ||
| onDelete(id) | ||
| } | ||
| onDelete(id) |
There was a problem hiding this comment.
onDelete is optional, perhaps this should remain in an if statement.
There was a problem hiding this comment.
I took it out because the button that calls the delete function is also conditionally rendered with the same check, seemed redundant. I can add this guard back in to be extra safe
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12233
ILabeltype from@influxdata/influxwherever possible, had to touch a lot of files because of thiscreateLabelAJAXwhich returns the newly created label for use in inline label creation (must be created the immediately added to a dashboard)createLabelinto two functions:createAndAddLabelcreateLabelChecklist: