Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admin to show error if password is not 8 characters #12072

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

Palakp41
Copy link
Contributor

@Palakp41 Palakp41 commented Feb 21, 2019

Closes #12028

Briefly describe your proposed changes:
Update admin page to not proceed to next step if there is an error with passwords that are not 8 characters long

  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

kapture 2019-02-21 at 11 43 50

ui/src/onboarding/actions/index.ts Show resolved Hide resolved
ui/src/onboarding/actions/index.ts Outdated Show resolved Hide resolved
ui/src/shared/copy/notifications.ts Show resolved Hide resolved
@Palakp41 Palakp41 force-pushed the fix/admin-step-notify branch from 8192f90 to a893e7f Compare February 21, 2019 21:31
@Palakp41 Palakp41 merged commit 4407be1 into master Feb 21, 2019
@mark-rushakoff mark-rushakoff deleted the fix/admin-step-notify branch February 22, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants