Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to view the influxdb_v2 output for telegraf #14924

Closed
russorat opened this issue Sep 4, 2019 · 14 comments · Fixed by #15674
Closed

Add the ability to view the influxdb_v2 output for telegraf #14924

russorat opened this issue Sep 4, 2019 · 14 comments · Fixed by #15674
Assignees
Labels
difficulty/medium Resolving this issue should take up to a week

Comments

@russorat
Copy link
Contributor

russorat commented Sep 4, 2019

many people already have telegraf configured for writing data in and they just need to add a new output for influxdb_v2. We need to add a way for the user to view just the output config for telegraf instead of having to create a new config and just pulling the output section.

Maybe just a new button next to the create configuration button that just shows the output section and gives the user the option to copy or download. the name of the downloaded file should be outputs.influxdb_v2.conf

image

image

@desa desa added difficulty/low Resolving this issue should take a day or two. ui/needs-design labels Sep 13, 2019
@alexpaxton alexpaxton removed their assignment Oct 14, 2019
@desa
Copy link
Contributor

desa commented Oct 14, 2019

@alexpaxton which project board should this issue be on?

@alexpaxton
Copy link
Contributor

@desa I think monitoring is the correct spot

@desa desa added difficulty/medium Resolving this issue should take up to a week and removed difficulty/low Resolving this issue should take a day or two. labels Oct 21, 2019
@russorat
Copy link
Contributor Author

  • There should be a comment in the modal letting users know that The USER_TOKEN can be generated on the Tokens tab. with a link to the tokens tab.
  • The output config can be pulled from the telegrafs API i believe
  • The button to create this should be prominent and distinguishable from the Create Configuration button. FYI @alexpaxton

@russorat
Copy link
Contributor Author

connect #15521 (would be nice to synchronize the naming)

@drdelambre drdelambre self-assigned this Oct 28, 2019
@drdelambre
Copy link
Contributor

i can't find the api endpoint for this in the swagger docs. I'll take a link if anyone has one, or we could scope this under monaco work (code folding), or we can make a fragile (but maybe still ok) solution and just remove everything above the [[outputs.influxdb_v2]] keyword.

@desa
Copy link
Contributor

desa commented Oct 29, 2019

i can't find the api endpoint for this in the swagger docs.

I don't think that any such endpoint exists.

or we can make a fragile (but maybe still ok) solution and just remove everything above the [[outputs.influxdb_v2]] keyword.

I think this should be a good first pass. I'd imagine that section of the config is pretty stable. Might be good to do this as a first iteration and to open up an issue that does it genericly using an API endpoint in the future.

@drdelambre
Copy link
Contributor

dug into this more. without api work, we could hardcode the output as a string, and populate it with the current org and url of the cloud server, but how does the user define the bucket that they want to connect to?

@drdelambre
Copy link
Contributor

would adding the button here (next to the dropdown, with phrasing like "just the output") have the same effect?
Screen Shot 2019-10-29 at 9 03 27 AM

@alexpaxton
Copy link
Contributor

@drdelambre I'd stick the button next to the Create Config button in the index view. Alternatively (or additionally) you could add a View Outputs button on each config

@drdelambre
Copy link
Contributor

i was thinking of doing the later as well (after one creates a config) but for creation, the user still needs to select a bucket before we can approximate a config (considering they may have more than one bucket in the case of a migration)

@russorat
Copy link
Contributor Author

russorat commented Oct 29, 2019

@desa
Copy link
Contributor

desa commented Oct 29, 2019

@russorat there's not an endpoint you can get that value without creating a telegraf.

@russorat
Copy link
Contributor Author

russorat commented Oct 30, 2019

if there's no api, let's hardcode for now.
use an env var for $INFLUX_TOKEN
I'd like to have the bucket selection in there though so the user can select the bucket they want to write to in a selector and have it update the config.

@drdelambre
Copy link
Contributor

got here today:
Kapture 2019-10-30 at 17 31 50
I'm already chasing down an example of a label with a dropdown, but open to more feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/medium Resolving this issue should take up to a week
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants