fix(task): inactive task runs when updated

Fixes #21874
influxdata · Aug 16, 2021 · 96f8ff8 · 96f8ff8
1 parent d677fa1
commit 96f8ff8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -80,6 +80,7 @@ This release adds an embedded SQLite database for storing metadata required by t
 1. [22059](https://github.com/influxdata/influxdb/pull/22059): Copy names from mmapped memory before closing iterator
 1. [22186](https://github.com/influxdata/influxdb/pull/22186): Preserve comments in flux queries when saving task definitions
 1. [#22174](https://github.com/influxdata/influxdb/pull/22174): systemd service -- handle 40x and block indefinitely
+1. [#22211](https://github.com/influxdata/influxdb/pull/22211): Prevent scheduling an inactivated tasks after updating it
 
 ## v2.0.7 [2021-06-04]
 

diff --git a/task/backend/coordinator/coordinator.go b/task/backend/coordinator/coordinator.go
@@ -135,7 +135,7 @@ func (c *Coordinator) TaskUpdated(ctx context.Context, from, to *taskmodel.Task)
 		if err := c.sch.Release(sid); err != nil && err != taskmodel.ErrTaskNotClaimed {
 			return err
 		}
-	} else {
+	} else if to.Status == string(taskmodel.TaskActive) {
 		if err := c.sch.Schedule(t); err != nil {
 			return err
 		}