fix: remove flags field #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps open-telemetry/opentelemetry-collector-contrib#29896 The flags field is set as an unsigned integer, which is not compatible with InfluxDB 1.x. Luckily, the field is also not useful, as it stores a value chosen from an enum containing no useful values. In this change, the flags field is removed from conversion. If it needs to be added in the future, we can expect that enough time will have passed that retention policies will have removed the prior `flags` field.
jacobmarble
added a commit
to influxdata/telegraf
that referenced
this pull request
May 25, 2024
This update preemptively fixes open-telemetry/opentelemetry-collector-contrib#29896 via influxdata/influxdb-observability#305
This was referenced May 25, 2024
jacobmarble
added a commit
to influxdata/telegraf
that referenced
this pull request
May 26, 2024
This update preemptively fixes open-telemetry/opentelemetry-collector-contrib#29896 via influxdata/influxdb-observability#305
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
May 27, 2024
**Description:** <Describe what has changed.> This change removes the Metric signal `flags` field to/from InfluxDB conversion. The InfluxDB field is type `uint` which is not supported in InfluxDB v1 AND the Metric `flags` field is not particularly useful (yet) in OpenTelemetry. **Link to tracking Issue:** <Issue number if applicable> Fixes #29896 **Testing:** Material code changes and tests in influxdata/influxdb-observability#305 **Documentation:** <Describe the documentation added.> Small changes to docs in influxdata/influxdb-observability#305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps open-telemetry/opentelemetry-collector-contrib#29896
The flags field is set as an unsigned integer, which is not compatible with InfluxDB 1.x. Luckily, the field is also not useful, as it stores a value chosen from an enum containing no useful values.
In this change, the flags field is removed from conversion. If it needs to be added in the future, we can expect that enough time will have passed that retention policies will have removed the prior
flagsfield.There are other fields that use the unsigned integer type, but those fields belong to Logs and Traces, which shouldn't be used with InfluxDB 1.x anyhow.