Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added callback function for getting profilers #393

Merged
merged 10 commits into from
Jan 17, 2022
Merged

feat: added callback function for getting profilers #393

merged 10 commits into from
Jan 17, 2022

Conversation

michaelahojna
Copy link
Contributor

@michaelahojna michaelahojna commented Jan 13, 2022

Closes #389

Proposed Changes

Added callback function for getting profilers with example and test

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@michaelahojna michaelahojna changed the title Issue389 feat: added callback function for getting profilers Jan 13, 2022
@michaelahojna michaelahojna marked this pull request as ready for review January 13, 2022 10:01
@michaelahojna michaelahojna requested a review from rhajek January 13, 2022 10:20
@michaelahojna michaelahojna added this to the 1.25.0 milestone Jan 13, 2022
@michaelahojna michaelahojna requested a review from bednar January 13, 2022 12:31
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍

There are a few requirements that must be be satisfy before we accept the PR:

  1. Please add examples/query_with_profilers.py into examples/README.md.
  2. Please add note about possibility of callback function into section: Profile query in README.rst

and also:

CHANGELOG.md Outdated Show resolved Hide resolved
examples/query_with_profilers.py Outdated Show resolved Hide resolved
examples/query_with_profilers.py Outdated Show resolved Hide resolved
influxdb_client/client/flux_csv_parser.py Outdated Show resolved Hide resolved
influxdb_client/client/query_api.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #393 (7ba9349) into master (376f371) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   92.94%   92.95%   +0.01%     
==========================================
  Files          28       28              
  Lines        2395     2400       +5     
==========================================
+ Hits         2226     2231       +5     
  Misses        169      169              
Impacted Files Coverage Δ
influxdb_client/client/flux_csv_parser.py 98.00% <100.00%> (+0.02%) ⬆️
influxdb_client/client/query_api.py 98.31% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376f371...7ba9349. Read the comment docs.

@michaelahojna michaelahojna requested a review from bednar January 14, 2022 08:13
CHANGELOG.md Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
@bednar bednar merged commit 86c2d62 into master Jan 17, 2022
@bednar bednar deleted the Issue389 branch January 17, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pythonic interface to profile data
3 participants