Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MultiprocessingWriter to help user write data in independent OS process #356

Merged
merged 3 commits into from
Nov 12, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Nov 2, 2021

Closes #350

Proposed Changes

Add helper which help user to write data in separate OS process - it is useful for latency sensitive use-cases.

image
image
image

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review November 3, 2021 09:05
@bednar bednar requested a review from rhajek November 3, 2021 09:05
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #356 (ad1a91a) into master (bb378af) will increase coverage by 0.06%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
+ Coverage   92.84%   92.90%   +0.06%     
==========================================
  Files          27       28       +1     
  Lines        2306     2368      +62     
==========================================
+ Hits         2141     2200      +59     
- Misses        165      168       +3     
Impacted Files Coverage Δ
...luxdb_client/client/util/multiprocessing_helper.py 95.16% <95.16%> (ø)
influxdb_client/client/write_api.py 99.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb378af...ad1a91a. Read the comment docs.

@bednar bednar added this to the 1.24.0 milestone Nov 3, 2021
@bednar bednar removed this from the 1.24.0 milestone Nov 11, 2021
@bednar bednar force-pushed the feat/multiprocessing-writer branch from ad1a91a to b91b292 Compare November 11, 2021 13:11
@bednar bednar added the enhancement New feature or request label Nov 11, 2021
@bednar bednar merged commit 922477f into master Nov 12, 2021
@bednar bednar deleted the feat/multiprocessing-writer branch November 12, 2021 07:10
@bednar bednar added this to the 1.24.0 milestone Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement measures to avoid blocking when flushing batch
3 participants