Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Migration Guide #331

Merged
merged 17 commits into from
Oct 11, 2021
Merged

docs: add Migration Guide #331

merged 17 commits into from
Oct 11, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 22, 2021 •
edited
Loading

Closes #259

Proposed Changes

Added the MIGRATION_GUIDE.rst to help user migrate to new client.

image

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021 •
edited
Loading

Codecov Report

Merging #331 (5293880) into master (a0779ab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files          27       27           
  Lines        2226     2226           
=======================================
  Hits         2060     2060           
  Misses        166      166

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0779ab...5293880. Read the comment docs.

@bednar bednar requested a review from rhajek October 4, 2021 10:13
@bednar bednar marked this pull request as ready for review October 4, 2021 10:13
@bednar bednar force-pushed the docs/migration_guide branch from 720aa6b to 5293880 Compare October 4, 2021 11:14
rhajek
rhajek approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also document the migration from old create_user, drop_user -> UsersService

@bednar bednar merged commit 74d89a7 into master Oct 11, 2021
@bednar bednar deleted the docs/migration_guide branch October 11, 2021 09:12
@bednar bednar added this to the 1.22.0 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Migration from influxDB-Python
3 participants
@bednar @codecov-commenter @rhajek