Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Threshold domain models mapping, response types for DashboardService #290

Merged
merged 7 commits into from
Jul 26, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 20, 2021

Closes #288
Closes #282

Proposed Changes

  1. Use correct mapping for Threshold to be able use Check API.
  2. Use correct response types for DashboardService.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek July 20, 2021 09:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #290 (2325973) into master (025e97e) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   92.38%   92.61%   +0.23%     
==========================================
  Files          27       27              
  Lines        2168     2168              
==========================================
+ Hits         2003     2008       +5     
+ Misses        165      160       -5     
Impacted Files Coverage Δ
influxdb_client/api_client.py 68.91% <0.00%> (+1.12%) ⬆️
influxdb_client/client/util/date_utils.py 96.29% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025e97e...2325973. Read the comment docs.

@bednar bednar marked this pull request as ready for review July 20, 2021 09:27
@bednar bednar changed the title fix: threshold inheritance fix: Threshold domain models mapping Jul 20, 2021
@bednar bednar changed the title fix: Threshold domain models mapping fix: Threshold domain models mapping, response types for DashboardService Jul 21, 2021
@bednar bednar merged commit a26fc4c into master Jul 26, 2021
@bednar bednar deleted the fix/threshold_inheritance branch July 26, 2021 12:02
@bednar bednar added this to the 1.20.0 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check does not return threshold type, value, within, min and max [BUG] Unable to parse cell data
3 participants