-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): change examples to ES modules #518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sranka
force-pushed
the
517/examples_esmodule
branch
from
August 8, 2022 07:04
343a535
to
f1a6b2e
Compare
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 1 1
======================================
Misses 1 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sranka
force-pushed
the
517/examples_esmodule
branch
from
August 8, 2022 07:38
d5c3407
to
f0051f9
Compare
vlastahajek
reviewed
Aug 8, 2022
vlastahajek
approved these changes
Aug 8, 2022
Co-authored-by: Vlasta Hajek <[email protected]>
…b-client-js into 517/examples_esmodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517
Proposed Changes
Examples changed in the following way:
js
files renamed tomjs
files (to work properly also in typescript)follow-redirects
example was repairedeslint
configuration repaired to include also .mjs filesChecklist
yarn test
completes successfully