Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spec): Fix duplicate definitions #5189

Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix(spec): Fix duplicate definitions #5189

merged 1 commit into from
Sep 12, 2022

Conversation

pierwill
Copy link
Contributor

@pierwill pierwill commented Sep 11, 2022

Rename some rules for the builtin statement to avoid ambiguity.

Closes #5186.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
    N/A
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
    N/A
  • 📖 If language features are changing, ensure docs/Spec.md has been updated
    No feature changes, but this does update the specification.

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@pierwill pierwill requested a review from a team as a code owner September 11, 2022 17:50
@pierwill pierwill requested review from wolffcm and nathanielc and removed request for a team September 11, 2022 17:50
Rename some rules for the builtin statement to avoid ambiguity.
@pierwill
Copy link
Contributor Author

Does this need changes in source code as well?

@nathanielc
Copy link
Contributor

Does this need changes in source code as well?

It does not, the source code will already have used unique function names for the production rules.

@pierwill pierwill merged commit 1ec2dc8 into master Sep 12, 2022
@pierwill pierwill deleted the pierwill/spec-dedup branch September 12, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting definitions in SPEC.md
2 participants