Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(join): better error when joining empty table #5171

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

scbrickley
Copy link
Contributor

@scbrickley scbrickley commented Sep 6, 2022

Fixes #5134

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@scbrickley scbrickley requested a review from a team as a code owner September 6, 2022 16:14
@scbrickley scbrickley requested review from Marwes and jsternberg and removed request for a team September 6, 2022 16:14
Copy link
Contributor

@Marwes Marwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a better error message, but shouldn't joining with an empty table just output an empty table? No need to actually error here?

@Marwes
Copy link
Contributor

Marwes commented Sep 7, 2022

I guess we can't construct the type for the output if we try to construct an empty table? (Which is annoying and should be fixed, it is just a bit of a mess)

@scbrickley
Copy link
Contributor Author

Hmmm, that's a fair point. Maybe I can catch this condition earlier in the transformation and output an empty table before we ever check the column types. I'll tinker with it and get back to you.

@scbrickley
Copy link
Contributor Author

I guess we can't construct the type for the output if we try to construct an empty table? (Which is annoying and should be fixed, it is just a bit of a mess)

This is the main blocker here. I'm going to merge this PR as is and we can discuss better solutions another time.

@scbrickley scbrickley merged commit 383f5fe into master Sep 7, 2022
@jacobmarble jacobmarble deleted the fix/join-empty-table branch January 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

join.tables() method: "full" with an empty table returns "table is missing label _value"
2 participants