Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update package for Spec in headless repl #5138

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

onelson
Copy link
Contributor

@onelson onelson commented Aug 26, 2022

Spec was moved during #5116.

This diff updates the import path in the headeless repl to match.

Currently there are no unit tests for this binary, so I had to manually verify the change:

$ go run internal/cmd/headless_repl/main.go                                                                                                                
{"jsonrpc":"2.0","method":"Service.DidOutput","params":[{"input":"now()"}]}                                                                                
{"id":null,"result":{"Result":"2022-08-26T21:07:16.304361483Z"},"error":null}                                                                              
^C^C^C^\SIGQUIT: quit

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code (manually verified)
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/ N/A
  • 📖 If language features are changing, ensure docs/Spec.md has been updated N/A

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

`Spec` was moved during <#5116>.

This diff updates the import path in the headeless repl to match.
@onelson
Copy link
Contributor Author

onelson commented Aug 26, 2022

@Westonside I don't see any tests for the headless repl binary, so I'm not sure how to verify this change. Do you have a recommendation for how to test manually? Maybe you can verify on your side by rebasing on top of this branch?

@onelson onelson marked this pull request as ready for review August 26, 2022 21:08
@onelson onelson requested a review from a team as a code owner August 26, 2022 21:08
@onelson onelson merged commit 3574c3a into master Aug 26, 2022
@onelson onelson deleted the fix/repl-spec branch August 26, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants