Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): temporarily remove test for duplicates since it causes conflicts downstream #5098

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

jsternberg
Copy link
Contributor

Methods of testing that use the zip file erroneously include the
duplicate testdata in the group of data that gets tested. This causes it
to output an error.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

…licts downstream

Methods of testing that use the zip file erroneously include the
duplicate testdata in the group of data that gets tested. This causes it
to output an error.
@jsternberg jsternberg requested a review from a team as a code owner August 15, 2022 17:13
@jsternberg jsternberg requested review from Marwes and removed request for a team August 15, 2022 17:13
Copy link

@wolffcm wolffcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I noticed that the file name contains the hash last week. Do we need an issue for this?

@jsternberg
Copy link
Contributor Author

I'll try to follow up with a change shortly. Otherwise, I'll make an issue.

@jsternberg jsternberg merged commit 0e6a1dd into master Aug 15, 2022
@jsternberg jsternberg deleted the fix/test-cmd-revert-duplicate-test branch August 15, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants