feat(stdlib): switch testing.diff to use experimental.diff permanently #5091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
requested review from
skartikey and
lwandzura
and removed request for
a team
sanderson
approved these changes
Aug 12, 2022
skartikey
approved these changes
Aug 12, 2022
jsternberg
force-pushed
the
feat/testing-experimental-diff
branch
from
0f065c6
to
bc567c9
Compare
This was hidden behind a feature flag in case it caused a problem. I have not seen any problem yet so I'm going to assume this is a relatively safe change. This should only affect those using `testing.diff()` which should be a small population of users if any.
jsternberg
force-pushed
the
feat/testing-experimental-diff
branch
from
bc567c9
to
9b344f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was hidden behind a feature flag in case it caused a problem. I
have not seen any problem yet so I'm going to assume this is a
relatively safe change. This should only affect those using
testing.diff()which should be a small population of users if any.Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.