feat(plan): generalize attributes in planner #4982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolffcm
requested review from
OfTheDelmer and
adrian-thurston
and removed request for
a team
| return true | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
This is slick! ⬆️
adrian-thurston
approved these changes
Jul 11, 2022
OfTheDelmer
approved these changes
Jul 12, 2022
| ts []execute.Transformation | ||
| a execute.Administration | ||
| id execute.DatasetID | ||
| factor int |
wolffcm
force-pushed
the
feat/planner-attributes
branch
from
9ad6c4d
to
4cf67b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes creates a framework whereby plan nodes can model characteristics of the data they consume and produce. These characteristics are called
attributesin the code and currently there are three different kinds:collationto indicate data that is collated (sorted) by particular columnsparallel-runto indicate that operations are run in parallelparallel-mergeto indicate a plan node that represents a merging of parallel data streamsThe parallel attributes were previously existing, but with this set of changes it is the procedure specs themselves that describe whether run in parallel or if they merge parallel streams.
Different attributes being produced or required by a particular operation is expressed by implementing interfaces. The comment at the top of
attributes.godescribes this in more detail.This change set is mostly the same as the POC that was in #4902. There is a more comprehensive description over there, which is also valid for this PR. The main differences from this PR are changes that were required to allow the tests in
parallel_test.goto pass.This work is part of (but does not complete) #4628.